Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: deny redundant_field_names #4101

Merged
merged 1 commit into from
Jul 13, 2024
Merged

clippy: deny redundant_field_names #4101

merged 1 commit into from
Jul 13, 2024

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jul 12, 2024

Pull Request Overview

Here's a bigger one. Are we far enough along our Rust journey to enable this lint?

I think once it doesn't seem strange to not call return at the end of a function this is the next step.

Testing Strategy

cargo clippy

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added sam4l Change pertains to the SAM4L MCU. tock-libraries This affects libraries supported by the Tock project WG-OpenTitan In the purview of the OpenTitan working group. stm32 Change pertains to the stm32 family of MCUSs component WG-Network In the purview of the Network working group. labels Jul 12, 2024
lschuermann
lschuermann approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. I really don't have too much of a preference either way, but I think this is good in the name of consistency.

@alevy alevy added the last-call Final review period for a pull request. label Jul 12, 2024
@alevy alevy added this pull request to the merge queue Jul 13, 2024
Merged via the queue into master with commit 634b577 Jul 13, 2024
18 checks passed
@alevy alevy deleted the clippy-redundant_field_names branch July 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lschuermann lschuermann lschuermann approved these changes

@alistair23 alistair23 alistair23 approved these changes

@alevy alevy alevy approved these changes

Assignees
No one assigned
Labels
component last-call Final review period for a pull request. sam4l Change pertains to the SAM4L MCU. stm32 Change pertains to the stm32 family of MCUSs tock-libraries This affects libraries supported by the Tock project WG-Network In the purview of the Network working group. WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bradjc @alevy @alistair23 @lschuermann