Add contributor-count axiom #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds axiom to enable rules only on projects with a certain amount of contributors. Uses node-gitlog library to get the contributor count of the repository. Some simple tests are also included. See issue todogroup#169 Signed-off-by: Yann Jorelle <yann.jorelle@nokia.com>
yannjor
force-pushed
the
contributor-count-axiom
branch
from
1441095
to
65ee20d
Compare
|
@trevmex Would you have time to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See issue #169
Proposed Changes
Adds axiom to enable rules only on projects with a certain amount of contributors. Uses the node-gitlog library to get the contributor count of the repository by looking at the commit authors. This result can be a bit higher than the actual contributor count in some cases, as some authors could be bots or use different names in their commits but it seems to be quite accurate.
The axiom can be included and used like any other axiom, but it also supports the greater than or lesser than symbols. See tests/package/repolint.json for an example.
Test Plan
Some tests are included in
tests/axioms/contributor_count_test.js.