Dropbox v2 - Beta

[beavel]

This PR represents a working version against Dropbox v2, which should complete #481. I've only tested it on Android 7.0 at the moment, but was able to get it to load my todo, add tasks, and sync completions. The browsing for directory also works as tested in a limited fashion. This may be a bit of rough hack as I'm not fully versed in the event cycle of Android apps, but I tried to make as limited code changes as necessary to replace the functionality. Not sure what the next steps are from here, but I can build successfully and run by creating a dropbox.xml and commenting out the resValue for dropbox in the debug gradle configuration.

What I know needs to be handled/decided on:

• How to handle upgrades - I've only installed fresh on an old phone. Anything special that needs to be done.
• Signing the release version
• Dropbox API key to use - I created one for personal use/testing.
• Re-enable proguard if needed

[dae3]

@beavel this looks good. I independently started the same work before noticing your PR. We have made almost exactly the same changes but yours is complete. I haven't fixed the authentication code yet.

I don't have the old version to upgrade from but from considering the code I think it should just be updating the SharedPreferences to purge the old authentication details and forcing re-authentication.

I can't help with signing or a more official Dropbox API key - @evanp do you know who has ownership of the signing key and Dropbox API key used by the currently published app?

It's sideloaded on my phone now to get some real-world testing.

[beavel]

@dae3 I'm glad this is working for you! Also its good to know I was on the right track with the changes since we had the same ones.

I haven't installed this on my main phone as I still have my old credentials there and that will be my one opportunity to work through the upgrade process flow with cleaning out credentials. If there is no movement no this PR in the near future, I might just reinstall and sideload to get my own real-world testing in as well. Going to be patient and hope that we can get this pushed out to other users though.

[dae3]

Hey @beavel I'm seeing weird corruption in todo.txt after editing (add, change, complete) on the app. It looks like the unicode byte order is being reversed at the point of the edit, making the file a mess in desktop editors (gvim and notepad).

I've just spent an hour repairing my todo.txt with a hex editor :-( . I'll try to reproduce later in the week.

[herrold]

@evanp

You appear to have commits ... the Android client is still broken a year later as Dropbox turned down the v1 API. Could you please apply this diff ?

Thank you

[beavel]

@dae3 Did you get a chance to look into the file corruption issue? I haven't had time recently to look and was just wondering if you got a chance to look a little further. Still haven't installed it on my main phone, but I might here soon if there is no further activity on this PR.

[dae3]

Not yet, I've actually being playing with doing a complete Material Design refresh and cutting out the ActionBarSherlock dependency, because that was more fun :-) It's almost done too, I just have to finish refactoring preferences into Fragments, then do the landscape-large variant layouts. I'm also suspecting the cause is not the app but something else in my setup (Dropbox synced to multiple machines, one Linux, one Windows perhaps?). Looking at my todo.txt in the Dropbox online editor is fine, and within the app it's also fine.

…

On Sun, 7 Oct 2018 at 08:49, Brian Vander Lugt ***@***.***> wrote: @dae3 <https://github.com/dae3> Did you get a chance to look into the file corruption issue? I haven't had time recently to look and was just wondering if you got a chance to look a little further. Still haven't installed it on my main phone, but I might here soon if there is no further activity on this PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#509 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APsCHoE50AAvI5LwDxDruLnOjXqtXDE1ks5uiSVvgaJpZM4VGDF7> .

[dae3]

@beavel I've had no file corruption for 2 weeks now, after carefully manually cleaning up my todo.txt file back to 8 bit ASCII.

I can't explain how it occurred but it hasn't returned, despite daily use of the app and desktop text editors to maintain the

[kvithayathil]

@dae3 i was about to work on a project upgrade to android studio 3.3.1 but I saw that you've already done it. Look forward to your work getting merged! 👍