Actually test (and fix) that the default action parameter is received…

… by the action

The foo2 action needs to print its parameters (instead of hard-coding "foo" if no parameters are passed (which also is broken because the $# is already expanded in the here-doc)), and the test needs to include "foo" (instead of "bar") to match the (reused) expected output.

The resulting output of "foo2 foo" shows that the code actually had a bug: The first argument needs to be dropped from the action arguments, as it's already used as the action name.

tests/t0002-actions.sh

@@ -16,10 +16,8 @@ echo "TODO: foo"
 EOF
 chmod +x foo
 
-cat > foo2 << EOF
-if [ "$#" -eq 0 ]; then
-    echo "TODO: foo"
-fi
+cat > foo2 << 'EOF'
+echo "TODO: $*"
 EOF
 chmod +x foo2
 
@@ -47,7 +45,7 @@ test_expect_success 'custom action (env variable)' '
 test_expect_success 'custom action (default action)' '
     mkdir .todo.actions.d
     cp foo2 .todo.actions.d/
-    TODOTXT_DEFAULT_ACTION="foo2 bar" todo.sh > output;
+    TODOTXT_DEFAULT_ACTION="foo2 foo" todo.sh > output;
     test_cmp expect output && rm -rf .todo.actions.d
 '
 

todo.sh

@@ -987,7 +987,7 @@ else
     actionarray=($action)
     if [ -d "$TODO_ACTIONS_DIR" -a -x "$TODO_ACTIONS_DIR/${actionarray[0]}" ]
     then
-      "$TODO_ACTIONS_DIR/${actionarray[0]}" $action
+      "$TODO_ACTIONS_DIR/${actionarray[0]}" "${actionarray[@]:1}"
       exit $?
     fi
 fi