Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch for MacOS 10.13 when checking 'date' command #278

Closed
wants to merge 1 commit into from

Conversation

NightFlyer
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
    It does now that the harness correctly processes dates on Mac OS 10.13!
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
    Fix test harness for MacOS 10.13 so that date tests work correctly.
  • Steps for the reviewer(s) on how they can manually QA the changes.
    Run on MacOS 10.13
  • Have a fixes #XX reference to the issue that this pull request fixes.
    fixes Test harness doesn't support Mac OS 10.13 #277

@karbassi karbassi requested review from evanp and inkarkat April 11, 2019 17:53
Copy link
Member

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never been involved in the MacOS platform (best I could do was testing on BSD, as I don't have any Apple hardware). This change is making the ugly stuff a bit worse, but if it's needed... The alternative would be to drop those special cases and demand that the user supplies a compatible date wrapper.

@eightyfive
Copy link
Contributor

I did a smaller (and more future prone) fix FYI:
#291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test harness doesn't support Mac OS 10.13
3 participants