-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(oxlint): configure rule categories in oxlint.json #8494
chore(oxlint): configure rule categories in oxlint.json #8494
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e689f98. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8494 +/- ##
=======================================
Coverage 70.12% 70.12%
=======================================
Files 528 528
Lines 33259 33259
Branches 2931 2931
=======================================
Hits 23324 23324
Misses 9587 9587
Partials 348 348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What This PR Does
Moves category-based configuration from CLI args in
lint:ox
tooxlint.json
.We are adding support for the
plugins
field in the next release, and we ironed out how CLI-based rule configuration merges with file-based rule configuration (see: oxc-project/oxc#6088). Rules that should have been enabled before will now be enabled, and due to this I also fixed a violation ofeslint/no-unsafe-optional-chaining
that was not caught before.This is part of an ongoing effort to keep our ecosystem CI nice and green. Thank you for using oxlint ⚓