Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oxlint): configure rule categories in oxlint.json #8494

Conversation

DonIsaac
Copy link
Contributor

What This PR Does

Moves category-based configuration from CLI args in lint:ox to oxlint.json.

We are adding support for the plugins field in the next release, and we ironed out how CLI-based rule configuration merges with file-based rule configuration (see: oxc-project/oxc#6088). Rules that should have been enabled before will now be enabled, and due to this I also fixed a violation of eslint/no-unsafe-optional-chaining that was not caught before.

This is part of an ongoing effort to keep our ecosystem CI nice and green. Thank you for using oxlint ⚓

Copy link

graphite-app bot commented Oct 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

nx-cloud bot commented Oct 15, 2024

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (691e1c2) to head (e689f98).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8494   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files         528      528           
  Lines       33259    33259           
  Branches     2931     2931           
=======================================
  Hits        23324    23324           
  Misses       9587     9587           
  Partials      348      348           
Flag Coverage Δ
server-test 76.82% <ø> (ø)
unittest 45.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn merged commit 9970138 into toeverything:canary Oct 15, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants