Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkeddoc can not query with IME #8433

Closed
lawvs opened this issue Sep 23, 2024 · 1 comment
Closed

Linkeddoc can not query with IME #8433

lawvs opened this issue Sep 23, 2024 · 1 comment
Labels
mod:cursor Module: related to native cursor mod:link Related to hyperlink or bi-directional links mod:rich-text Module: related to rich-text editing (including Virgo) mod:widget Related to positioned menus

Comments

@lawvs
Copy link
Collaborator

lawvs commented Sep 23, 2024

The LinkedDocPopover disappears when inputting with an IME.

Screen.Recording.2024-09-23.at.15.43.20.mov
Screen.Recording.2024-09-23.at.15.44.16.mov

Related to #8368

Debug stack:

LinkedDocPopover
  connectedCallback
    createKeydownObserver onInput
      this.inlineEditor.slots.renderComplete.once(this._updateLinkedDocGroup);

  _updateLinkedDocGroup
    const query = this._query;
    if (query === null) { this.abortController.abort(); }

  private get _query() {
    return getQuery(this.inlineEditor, this._startRange);
  }

getQuery
  const textNode = nativeRange.startContainer;
  if (textNode.nodeType !== Node.TEXT_NODE) {
    return null;
  }
@lawvs lawvs added mod:cursor Module: related to native cursor mod:rich-text Module: related to rich-text editing (including Virgo) mod:widget Related to positioned menus mod:link Related to hyperlink or bi-directional links labels Sep 23, 2024
@lawvs
Copy link
Collaborator Author

lawvs commented Sep 27, 2024

Fixed in #8481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:cursor Module: related to native cursor mod:link Related to hyperlink or bi-directional links mod:rich-text Module: related to rich-text editing (including Virgo) mod:widget Related to positioned menus
Projects
Archived in project
Development

No branches or pull requests

1 participant