Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): can not search in at menu with IME #8481

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Sep 27, 2024

Close BS-1531

const curRange = inlineEditor.getInlineRange();
if (!startRange || !curRange) {
return null;
}

When compositionend event is emitted, the node in the current native range is a ELEMENT_NODE not a TEXT_NODE in MacOS. That will make the searching query of @ menu to be null, and then the menu will be auto-closed.

<div contenteditable="true" class=" inline-editor " data-v-root="true">

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 3:38pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 3:38pm

Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: f472444

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 27, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Sep 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f472444. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Sep 27, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.03 MB (-0.02% 🔽)
@blocksuite/affine/block-std 153.14 KB (0%)
@blocksuite/affine/block-std/gfx 75.83 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.82 KB (0%)
@blocksuite/affine/global/env 231 B (0%)
@blocksuite/affine/global/exceptions 552 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 77.06 KB (0%)
@blocksuite/affine/inline 30.45 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.84 MB (+0.01% 🔺)
@blocksuite/affine/blocks 1.92 MB (-0.02% 🔽)
@blocksuite/affine/blocks/schemas 85.39 KB (0%)

@L-Sun L-Sun marked this pull request as ready for review September 27, 2024 15:04
@L-Sun L-Sun requested a review from a team as a code owner September 27, 2024 15:04
@L-Sun L-Sun requested a review from Flrande September 27, 2024 15:07
@L-Sun L-Sun added the merge label Sep 27, 2024
Copy link

graphite-app bot commented Sep 27, 2024

Merge activity

  • Sep 27, 11:36 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 27, 11:36 AM EDT: L-Sun added this pull request to the Graphite merge queue.
  • Sep 27, 11:41 AM EDT: L-Sun merged this pull request with the Graphite merge queue.

Close [BS-1531](https://linear.app/affine-design/issue/BS-1531/macos-chrome-无法在menu中使用中文搜索)

https://github.com/toeverything/blocksuite/blob/3ecef3d1d57dd77314c0b13e02d2bda6efc41911/packages/blocks/src/_common/components/utils.ts#L24-L27

When `compositionend` event is emitted, the node in the current native range is a `ELEMENT_NODE` not a `TEXT_NODE` in MacOS. That will make the searching query of @ menu to be null, and then the menu will be auto-closed.
```
<div contenteditable="true" class=" inline-editor " data-v-root="true">
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants