-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blocks): can not search in at menu with IME #8481
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f472444. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
size-limit report 📦
|
Merge activity
|
Close [BS-1531](https://linear.app/affine-design/issue/BS-1531/macos-chrome-无法在menu中使用中文搜索) https://github.com/toeverything/blocksuite/blob/3ecef3d1d57dd77314c0b13e02d2bda6efc41911/packages/blocks/src/_common/components/utils.ts#L24-L27 When `compositionend` event is emitted, the node in the current native range is a `ELEMENT_NODE` not a `TEXT_NODE` in MacOS. That will make the searching query of @ menu to be null, and then the menu will be auto-closed. ``` <div contenteditable="true" class=" inline-editor " data-v-root="true"> ```
3ecef3d
to
f472444
Compare
Close BS-1531
blocksuite/packages/blocks/src/_common/components/utils.ts
Lines 24 to 27 in 3ecef3d
When
compositionend
event is emitted, the node in the current native range is aELEMENT_NODE
not aTEXT_NODE
in MacOS. That will make the searching query of @ menu to be null, and then the menu will be auto-closed.