-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve open link on link popup #8462
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5739eea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
size-limit report 📦
|
Merge activity
|
Closes [BS-1496](https://linear.app/affine-design/issue/BS-1496/当-hover-affine-link-时,-单击-link-popup-上的-open-link-也应该需要判断下站内链接的情况) When a user opens a link on a link-popup, it is also necessary to identify whether it is an in-app link. <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/8ypiIKZXudF5a0tIgIzf/8bc7efee-f158-4fac-815d-39f15139d55e.mov"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/8ypiIKZXudF5a0tIgIzf/8bc7efee-f158-4fac-815d-39f15139d55e.mov"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/8ypiIKZXudF5a0tIgIzf/8bc7efee-f158-4fac-815d-39f15139d55e.mov">Screen Recording 2024-09-25 at 16.24.35.mov</video>
3f7a79c
to
5739eea
Compare
Closes BS-1496
When a user opens a link on a link-popup, it is also necessary to identify whether it is an in-app link.