Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard controller should attach event on document #8801

Conversation

doouding
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: cea0a56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 6:40am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 6:40am

Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

doouding commented Nov 25, 2024


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cea0a56. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 25, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.11 MB (+0.07% 🔺)
@blocksuite/affine/block-std 158.78 KB (-0.02% 🔽)
@blocksuite/affine/block-std/gfx 82.87 KB (+0.25% 🔺)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.9 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.66 KB (0%)
@blocksuite/affine/inline 32.66 KB (0%)
@blocksuite/affine/inline/consts 242 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.9 MB (-0.02% 🔽)
@blocksuite/affine/blocks 2 MB (+0.03% 🔺)
@blocksuite/affine/blocks/schemas 101.89 KB (0%)

@doouding doouding force-pushed the 11-25-fix_keyboard_controller_should_attach_event_on_document branch from 183652e to 331b9b1 Compare December 19, 2024 03:31
@doouding doouding requested review from L-Sun and Flrande December 19, 2024 03:37
Copy link

graphite-app bot commented Dec 19, 2024

Merge activity

@doouding doouding force-pushed the 11-25-fix_keyboard_controller_should_attach_event_on_document branch from 331b9b1 to cea0a56 Compare December 19, 2024 06:38
@graphite-app graphite-app bot merged commit cea0a56 into master Dec 19, 2024
36 checks passed
@graphite-app graphite-app bot deleted the 11-25-fix_keyboard_controller_should_attach_event_on_document branch December 19, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants