Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(edgeless): reduce redundant dom query per render #9016

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

doodlewind
Copy link
Member

This removes the green spikes during zooming, which is caused by per-render DOM queries in connector manager:

image

@doodlewind doodlewind requested a review from a team as a code owner December 18, 2024 16:24
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 031f096

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 4:31pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 4:31pm

Copy link

graphite-app bot commented Dec 18, 2024

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

nx-cloud bot commented Dec 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e102bb5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.11 MB (+0.06% 🔺)
@blocksuite/affine/block-std 158.8 KB (0%)
@blocksuite/affine/block-std/gfx 82.67 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.9 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.66 KB (0%)
@blocksuite/affine/inline 32.66 KB (0%)
@blocksuite/affine/inline/consts 242 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.9 MB (+0.02% 🔺)
@blocksuite/affine/blocks 2 MB (+0.04% 🔺)
@blocksuite/affine/blocks/schemas 101.89 KB (+14.55% 🔺)

@doodlewind doodlewind merged commit 54c5b4d into master Dec 18, 2024
35 checks passed
@doodlewind doodlewind deleted the doodl/perf branch December 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant