Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blocks): fix title and icon display issue in embed synced doc block #9031

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(blocks): fix title and icon display issue in embed synced doc block #9031

merged 1 commit into from
Dec 19, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 19, 2024 •
edited
Loading

Before

Screenshot 2024-12-19 at 19 24 54

After

Screenshot 2024-12-19 at 19 25 26

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:03pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 1:03pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 08a9d51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fundon Graphite App
Copy link
Contributor Author

fundon commented Dec 19, 2024

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 19, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 08a9d51. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@fundon fundon marked this pull request as ready for review December 19, 2024 11:25
@fundon fundon requested a review from a team as a code owner December 19, 2024 11:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.11 MB (+0.02% 🔺)
@blocksuite/affine/block-std 158.78 KB (0%)
@blocksuite/affine/block-std/gfx 82.87 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.9 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.66 KB (0%)
@blocksuite/affine/inline 32.66 KB (0%)
@blocksuite/affine/inline/consts 242 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.9 MB (+0.02% 🔺)
@blocksuite/affine/blocks 2 MB (-0.01% 🔽)
@blocksuite/affine/blocks/schemas 97.1 KB (0%)

@fundon fundon force-pushed the fundon/12_20_fix_title_and_icon_in_embed_synced_doc_block branch from d3b41e6 to f88cd7f Compare December 19, 2024 11:40
@fundon fundon changed the title fix(blocks): fix title and icon in embed synced doc block fix(blocks): fix title and icon display issue in embed synced doc block Dec 19, 2024
@fundon fundon added the merge label Dec 19, 2024
@fundon Graphite App
Copy link
Contributor Author

fundon commented Dec 19, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 19, 8:02 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 19, 8:02 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 19, 8:07 AM EST: A user merged this pull request with the Graphite merge queue.

@fundon
fix(blocks): fix title and icon display issue in embed synced doc blo…
08a9d51 
…ck (#9031)

### Before
<img width="859" alt="Screenshot 2024-12-19 at 19 24 54" src="https://github.com/user-attachments/assets/d7171168-7090-469c-9022-3339f3cb88a7" />

### After
<img width="855" alt="Screenshot 2024-12-19 at 19 25 26" src="https://github.com/user-attachments/assets/f6ea0f68-25db-40e3-ac01-69fc4cc4c6d2" />
@fundon fundon force-pushed the fundon/12_20_fix_title_and_icon_in_embed_synced_doc_block branch from f88cd7f to 08a9d51 Compare December 19, 2024 13:02
@graphite-app graphite-app bot merged commit 08a9d51 into master Dec 19, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fundon/12_20_fix_title_and_icon_in_embed_synced_doc_block branch December 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

Assignees

@fundon fundon

Labels
merge
Projects
BlockSuite Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fundon @Saul-Mirone