fix(blocks): text colors are not saved when importing to html #9042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #8479. I know this issue was assigned to @donteatfriedrice, so if he is currently working on it, feel free to close this PR.
When exporting to HTML, text color and text background color are not preserved.
Affine document:
Exported HTML:
Changes
Text with color or background color is now wrapped into a span with necessary color. Previously, colors were not supported
Problem
Although I have encountered a problem. Colors passed to a wrapping span are stored in css variables. There are no css variables in the html, which still leads to no colors in html. See the screenshots below
Before:
After:
Question
Should i convert the colors on the go, or better add missing css variables to html? What will you recommend? Any feedback will be highly appreciated!