-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce logging-derivation-annotations package. #1333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FunFunFine
requested review from
Odomontois,
danslapman,
catostrophe and
oskin1
as code owners
September 12, 2024 18:33
…rom derivation-annotations project;
use only the required options;
dos65
reviewed
Sep 13, 2024
.dependsOn(loggingStr) | ||
.dependsOn(loggingStr, loggingDerivationAnnotations) | ||
|
||
lazy val loggingDerivationAnnotations = projectMatrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add this porjetc to aggregated logging
module here -
Line 262 in f8d62e5
(loggingLogstashLogback, true, true), |
(loggingDerivationAnnotations, true, true)
Otherwise it won't be published
dos65
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR allows adding Loggable derivation annontations to clases that are sensetive to the dependencies.