Don't throw when in or out are closed. (#40)

toitware · Apr 10, 2024 · 7d01475 · 7d01475
1 parent a71c674
commit 7d01475
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/src/modules/quectel/quectel.toit b/src/modules/quectel/quectel.toit
@@ -179,17 +179,17 @@ class TcpSocket extends Socket_ with io.CloseableInMixin io.CloseableOutMixin im
     return 0
 
   close-reader_:
-    // TODO(florian): is this the right thing to do?
     // Do nothing.
 
   /**
   Closes the socket for write. The socket is still be able to read incoming data.
+  Deprecated. Call ($out).close instead.
   */
   close_write:
-    throw "UNSUPPORTED"
+    out.close
 
   close-writer_:
-    throw "UNSUPPORTED"
+    // Do nothing.
 
   // Immediately close the socket and release any resources associated.
   close:

diff --git a/src/modules/sequans/sequans.toit b/src/modules/sequans/sequans.toit
@@ -181,7 +181,6 @@ class TcpSocket extends Socket_ with io.CloseableInMixin io.CloseableOutMixin im
     return 0
 
   close-reader_:
-    // TODO(florian): is this the right way to close the reader?
     // Do nothing.
 
   /**
@@ -192,7 +191,7 @@ class TcpSocket extends Socket_ with io.CloseableInMixin io.CloseableOutMixin im
     out.close
 
   close-writer_:
-    throw "UNSUPPORTED"
+    // Do nothing.
 
   // Immediately close the socket and release any resources associated.
   close:

diff --git a/src/modules/ublox/ublox.toit b/src/modules/ublox/ublox.toit
@@ -158,10 +158,10 @@ class TcpSocket extends Socket_ with io.CloseableInMixin io.CloseableOutMixin im
   Deprecated. Use ($out).close instead.
   */
   close_write:
-    throw "UNSUPPORTED"
+    out.close
 
   close-writer_:
-    throw "UNSUPPORTED"
+    // Do nothing.
 
   // Immediately close the socket and release any resources associated.
   close: