Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a .vscodeignore. #234

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Add a .vscodeignore. #234

merged 7 commits into from
Nov 15, 2023

Conversation

floitsch
Copy link
Member

Reduces the size of the extension by about 1/2 (4MB).

kasperl
kasperl approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but it feels like we need to ship the webpack'ed bits, not the contents of the vscode/ directory with a few entries ignored.

Base automatically changed from floitsch/update-dependencies to master November 15, 2023 13:44
@floitsch
Copy link
Member Author

Agreed. Will look into it.

@floitsch floitsch merged commit bf8c2d7 into master Nov 15, 2023
1 check passed
@floitsch floitsch deleted the floitsch/update-dependencies.15.vscodeignore branch November 15, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperl kasperl kasperl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floitsch @kasperl