Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriber): Reduce retention period to fit in max message size #503

Merged
merged 2 commits into from
Feb 7, 2024

Commits on Feb 6, 2024

  1. feat(subscriber): Reduce retention period to fit in max message size

    If the initial update message would be too big for tokio-console's grpc
    decoder, reduce the retention period and try again.
    
    Currently the default retention period is 1 hour. That can easily grow
    to more than the max grpc decode message size (4 MiB), at which point
    tokio-console won't connect.
    
    There's really no minimum safe duration for retention. It depends on how
    busy the app is and on how much trace data runtime and tokio log. Here
    we repeatedly divide the retention period in half until it fits in the
    message.
    Graham King authored and grahamking committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a9e133f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    3711b9f View commit details
    Browse the repository at this point in the history