Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump the url to 2.5.4 #602

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Rustin170506
Copy link
Collaborator

@Rustin170506 Rustin170506 commented Dec 11, 2024

close #601

As Remedy said, because we are not directly dependent on idna. So we just need to bump the url to 2.5.4 or later.

After bump:

console on  pr/Rustin170506/602:rustin-patch-url-version [$] via 🦀 v1.83.0 cargo tree --invert -p idna 
idna v1.0.3
└── url v2.5.4
    └── color-eyre v0.6.3
        ├── tokio-console v0.1.13 (/Volumes/t7/code/console/tokio-console)
        └── xtask v0.1.0 (/Volumes/t7/code/console/xtask)

@Rustin170506 Rustin170506 requested a review from a team as a code owner December 11, 2024 13:37
@Rustin170506
Copy link
Collaborator Author

CI should be fixed at #603.

@Rustin170506 Rustin170506 requested a review from hds December 11, 2024 13:46
Copy link
Collaborator

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: Rustin170506 <tech@rustin.me>
@Rustin170506 Rustin170506 force-pushed the rustin-patch-url-version branch from 874758a to 0bd150e Compare December 12, 2024 13:09
@Rustin170506
Copy link
Collaborator Author

Just rebased on upstream, no other changes. So I will merge it.

@Rustin170506 Rustin170506 merged commit dd64629 into tokio-rs:main Dec 12, 2024
19 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-url-version branch December 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0421: idna accepts Punycode labels that do not produce any non-ASCII when decoded
2 participants