Don't crash on lazy_static init race #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The real lazy_static uses a lock to avoid races in initialization. We don't implement that lock yet, so our initialization can race. If we do, we should not crash like we did before. Fixes tokio-rs#126.
jonhoo
added a commit
to jonhoo/crossbeam
that referenced
this pull request
Apr 12, 2020
With this change, loom runs to completion on the treiber test!
I ran it with `LOOM_MAX_PREEMPTIONS=3`, and it took _forever_ (well, it
took 2h), but eventually finished with:
================== Iteration 112280000 ==================
Completed in 112291514 iterations
ok
With `LOOM_MAX_PREEMPTIONS=2` it "only" took 13 minutes, and finished
with:
================== Iteration 9680000 ==================
Completed in 9690926 iterations
ok
I updated the CI script to run with `LOOM_MAX_PREEMPTIONS=2`.
Note that this change depends on
tokio-rs/loom#125 and
tokio-rs/loom#128. The `patch` in the root
`Cargo.toml` should be removed once a new loom release is made.
hawkw
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real lazy_static uses a lock to avoid races in initialization. We
don't implement that lock yet, so our initialization can race. If we do,
we should not crash like we did before.
Fixes #126.