New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check rustfmt on CI #1389

Closed

Thomasdezeeuw opened this issue Nov 6, 2020 · 0 comments · Fixed by #1452

Labels

bug

Milestone

Collaborator

Thomasdezeeuw commented Nov 6, 2020

I don't think rustfmt is correctly run/checked any more. For example pr #1387, includes removed two empty lines which should never have been accepted in the first place (https://github.com/tokio-rs/mio/pull/1387/files#diff-18a0d97f7fd2d0be7bcf88ca6aca8f043379f1773fd75db078504ec4eb8edbc5L131).

Thomasdezeeuw added the bug label

Thomasdezeeuw added this to the V0.8 milestone

Thomasdezeeuw mentioned this issue

Fix rustfmt on CI #1452

Merged

Thomasdezeeuw closed this as completed in #1452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment