Support setting SO_LINGER on TcpSocket #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Thomasdezeeuw
approved these changes
Nov 6, 2020
|
Thanks @zekisherif. |
|
Just realized that the commit message should really be "Support getting SO_LINGER value". The setting of the linger value is meant for tokio TcpStream not mio. |
|
I missed it too, oh well.. it's committed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because tokio
TcpStreamand mioTcpStreamnow usestd::net::TcpStreamas the underlying stream, there isn't a way to set linger options.I'm aware of #1381 and the dislike of duplicating features. This is the last functionality I need.
The plan is to convert the stream by calling
as_raw_fd()and set the linger option.