Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax windows-sys dependency version #1570

Merged
merged 1 commit into from
May 3, 2022
Merged

Relax windows-sys dependency version #1570

merged 1 commit into from
May 3, 2022

Conversation

atouchet
Copy link
Contributor

@atouchet atouchet commented May 2, 2022

Was this supposed to be set to 0.36 exactly or was that an oversight from #1569?

@Noah-Kennedy
Copy link

@Thomasdezeeuw I don't see any reason for this to be necessary

@Noah-Kennedy
Copy link

I am pretty sure this is an oversight but I'd like to check with thomas

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Thomasdezeeuw Thomasdezeeuw merged commit dd61747 into tokio-rs:master May 3, 2022
@Thomasdezeeuw
Copy link
Collaborator

Thanks @atouchet.

@atouchet atouchet deleted the win branch May 3, 2022 14:42
@101100
Copy link

101100 commented Oct 4, 2022

With the very rapid release schedule of the windows-sys crate with apparently no regard for semantic versioning would you accept a PR to relax the version even further to either >0.36 or 0 (which is equivalent to 0.* as I understand it)?

@Thomasdezeeuw
Copy link
Collaborator

@101100 I don't think we can do that as windows-sys 0.37 is allowed to break the API, which means that at some point Mio might not build any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants