make log an optional dependency
#1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Mio depends on `log`. In rust-lang/log#552, the `log` maintainers aim to increase `log`'s MSRV to 1.60. This MSRV increase would impact Mio, which in turn, would impact Tokio. As of 1.25, Tokio supports Rust 1.49 with the intent of supporting it until March 2024. This commit makes `log` an optional dependency for those who wish to maintain a lower MSRV.
Closed
|
I don't think the CI failures are related. |
Noah-Kennedy
approved these changes
May 27, 2023
Thomasdezeeuw
approved these changes
May 27, 2023
|
I'll send a pr to fix the CI. |
|
@carllerche are there any Tokio versions still supported that use v0.7? If so we'll have to backport this. |
|
No, the earliest LTS that is still supported is the 1.18.x series, and we upgraded to mio v0.8 in the 1.17.0 release (link). |
This was referenced May 27, 2023
|
CI should be fixed by #1674, so I'm merging this. |
This was referenced May 27, 2023
This was referenced Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Mio depends on
log. In rust-lang/log#552, thelogmaintainers aim to increaselog's MSRV to 1.60. This MSRV increase would impact Mio, which in turn, would impact Tokio. As of 1.25, Tokio supports Rust 1.49 with the intent of supporting it until March 2024.This commit makes
logan optional dependency for those who wish to maintain a lower MSRV.