-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix a handful of lints, one of which was breaking the build (#65)
* native-tls: fix use of non-fmt panic in tests * fix some misc. clippy lints This branch fixes a number of lints. The most important one was the use of a non-`format_args!` expression in a `panic!` macro, which generates a compiler warning in recent Rust toolchains, which is breaking the CI `cargo check` run on PR #64. While I was here, I also fixed some miscellaneous Clippy lints, mostly in tests. These include: * Use of `clone()` on `SocketAddr`s (which implement `Copy`) * Unnecessary single-path-segment imports (which probably used to be `extern crate`s in earlier Rust?) * `'static` lifetimes in `const` type annotations (`const`s always have the `'static` lifetime) None of these were breaking the build on CI, but I figured I'd address them while I was fixing other lints. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
- Loading branch information
Showing
6 changed files
with
5 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters