Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark tokio futures as UnwindSafe #4414

Closed
CaptainMaso opened this issue Jan 20, 2022 · 3 comments
Closed

Mark tokio futures as UnwindSafe #4414

CaptainMaso opened this issue Jan 20, 2022 · 3 comments
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-fs Module: tokio/fs

Comments

@CaptainMaso
Copy link

Version
tokio = 1.15.0
tokio-macros = 1.7.0
tokio-util = 1.15.0

Platform
Linux 5.3.18-59.37-default 1 SMP x86_64 GNU/Linux

Description

Some tokio futures are not marked as unwind safe, making catching panics unwieldy and uncertain. I spoke with Alice who suggested I make a bug report about this.

I tried this code:

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=77e8b4432bd28f50080cbae9eb26b8ae

And the compiler reports that various futures produced (particularly by the tokio::fs module) are not UnwindSafe.
@CaptainMaso CaptainMaso added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Jan 20, 2022
@Darksonn Darksonn added E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-fs Module: tokio/fs labels Jan 21, 2022
@Hodkinson
Copy link
Contributor

I can take a look at this

Hodkinson added a commit to Hodkinson/tokio that referenced this issue Jan 23, 2022
@Hodkinson
runtime: mark JoinHandle as UnwindSafe (tokio-rs#4414)
debbbb7
@Hodkinson Hodkinson mentioned this issue Jan 23, 2022
Merged
Hodkinson added a commit to Hodkinson/tokio that referenced this issue Jan 24, 2022
@Hodkinson
runtime: mark JoinHandle as UnwindSafe for all T (tokio-rs#4414)
86370d5
@gwik
Copy link
Contributor

gwik commented Feb 10, 2022

Looks like it can be closed.

@CaptainMaso
Copy link
Author

Yep! Thanks everyone!

@abonander abonander mentioned this issue May 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-fs Module: tokio/fs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gwik @Darksonn @Hodkinson @CaptainMaso