-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tokio_test::io::Mock does not read actions from handle when used as writer #5813
Labels
Comments
pbrenna
changed the title
tokio_test::ioMock does not read actions from handle
tokio_test::ioMock does not read actions from handle when used as writer
Jun 23, 2023
pbrenna
changed the title
tokio_test::ioMock does not read actions from handle when used as writer
tokio_test::io::Mock does not read actions from handle when used as writer
Jun 23, 2023
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
This covers the case when a Mock is created without any action, for use with an Handle. Refs: tokio-rs#5813
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
When creating a tokio_test::io::Mock with no actions, bew actions were never fetched from the mock Handle. This change fetches an action from the Handle, if present. Fixes: tokio-rs#5813
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
This covers the case when a Mock is created without any action, for use with an Handle. Refs: tokio-rs#5813
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
When creating a tokio_test::io::Mock with no actions, bew actions were never fetched from the mock Handle. This change fetches an action from the Handle, if present. Fixes: tokio-rs#5813
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
This covers the case when a Mock is created without any action, for use with an Handle. Refs: tokio-rs#5813
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
When creating a tokio_test::io::Mock with no actions, bew actions were never fetched from the mock Handle. This change fetches an action from the Handle, if present. Fixes: tokio-rs#5813
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
This covers the case when a Mock is created without any action, for use with an Handle. Refs: tokio-rs#5813
pbrenna
pushed a commit
to pbrenna/tokio
that referenced
this issue
Jun 23, 2023
When creating a tokio_test::io::Mock with no actions, bew actions were never fetched from the mock Handle. This change fetches an action from the Handle, if present. Fixes: tokio-rs#5813
Darksonn
added
A-tokio-test
Area: The tokio-test crate
and removed
A-tokio
Area: The main tokio crate
labels
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
Platform
Linux lenovo-arch 6.3.8-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 14 Jun 2023 20:10:31 +0000 x86_64 GNU/Linux
Description
Expected output:
Actual output:
Additional notes
tokio/tokio-test/src/io.rs
Lines 422 to 425 in 2e62374
I suspect this is not correct
EDIT: I suspect instead that this is fine, but
self.inner.poll_action
should be called beforeself.inner.write
. Working on PR.The text was updated successfully, but these errors were encountered: