Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to newer nightly #1384

Closed
wants to merge 8 commits into from
Closed

chore: bump to newer nightly #1384

wants to merge 8 commits into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Aug 3, 2019

taiki-e added 4 commits August 3, 2019 14:28
`await_macro` feature has been removed in rust-lang/rust#62293.
Lifetime elision in `Pin<&(mut) Self>` has been allowed in rust-lang/rust#61207.
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@taiki-e
Copy link
Member Author

taiki-e commented Aug 3, 2019

Seems a rustfmt issue the same as #1335 (comment) is still happening (filed rust-lang/rustfmt#3725). I'm not sure about this issue...

@taiki-e
Copy link
Member Author

taiki-e commented Aug 3, 2019

I will try to change the rustfmt version to stable or beta (if it does not break the format by doing that).

@LucioFranco
Copy link
Member

@taiki-e can we stay on an older rust toolchain, I would rather like to stay on one whole chain than use parts.

@taiki-e
Copy link
Member Author

taiki-e commented Aug 4, 2019

@LucioFranco I see. It seems a PR has been submitted to fix the issue, so I will wait for the release of new nightly that including the changes.

@taiki-e taiki-e closed this Aug 4, 2019
@taiki-e taiki-e deleted the bump-nightly branch August 10, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants