Update the blocking threadpool so that threads that are idle are shut down. #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ALIVE seconds without any queued work will be shutdown.
|
I think ideally before we could do something like that, keep-alive should be configurable... |
100%... before 0.2 final I would like the threadpool implementation to be configurable as part of the runtime. I am punting on this initially though as I think it will be easier to polish all this stuff off once Tokio 0.2 is "feature complete. |
carllerche
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the blocking threadpool so that threads that are idle for KEEP_ALIVE seconds without any queued work will be shutdown. As of now, KEEP_ALIVE does nothing of consequence and threads that are spawned into the pool will never be shutdown during runtime.