Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix macOS ci on github actions #2602

Merged
merged 1 commit into from
Jun 10, 2020
Merged

chore: fix macOS ci on github actions #2602

merged 1 commit into from
Jun 10, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jun 10, 2020

Motivation

#2593 have only fixed the azure pipelines CI. (Only azure pipelines had a problem when I submitted #2593. This is because our github actions CI use rustc which is installed by default in images.)

Solution

@taiki-e taiki-e requested a review from Darksonn June 10, 2020 19:04
@taiki-e taiki-e added the A-ci Area: The continuous integration setup label Jun 10, 2020
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how the github workflow config works, but it appears that the github actions passed. 👍

@taiki-e taiki-e merged commit d223019 into tokio-rs:master Jun 10, 2020
@taiki-e taiki-e deleted the gha branch June 10, 2020 19:51
@Darksonn
Copy link
Contributor

Rust version 1.44.1 has been released with a fix for this. Should this be unpinned?

@taiki-e
Copy link
Member Author

taiki-e commented Jul 5, 2020

Yes, should be unpinned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants