io: update to Mio 0.7 #2893
Merged
io: update to Mio 0.7 #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes Mio an implementation detail, removing it from the public API.
ipetkov
approved these changes
Oct 2, 2020
seanmonstar
reviewed
Oct 2, 2020
seanmonstar
approved these changes
Oct 2, 2020
bdonlan
reviewed
Oct 2, 2020
tokio/src/signal/unix/driver.rs
Outdated
| // Mio 0.7 removed `try_clone()` as an API due to unexpected behavior | ||
| // with registering dups with the same reactor. In this case, duping is | ||
| // safe as each dup is registered with separate reactors **and** we | ||
| // only at least one dup to receive the notification. |
There was a problem hiding this comment.
We only expect at least one dup to receive the notification?
There was a problem hiding this comment.
All signal registrations are held in a global data structure. As long as some running SignalDriver gets woken, it will dispatch all pending signal notifications. A potential issue could be if we only wake one driver which isn't turning for whatever reason, but I believe this is unlikely
There was a problem hiding this comment.
I believe he was mostly commenting on the missing word :)
There was a problem hiding this comment.
Indeed. This threw me off a bit when reading this comment. It makes sense but took a bit of thinking to reconstruct the intent :)
bdonlan
approved these changes
Oct 2, 2020
This was referenced Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes Mio an implementation detail, removing it from the
public API.
This is based on #1767.
Remaining