Remotely abort tasks on JoinHandle::abort #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
approved these changes
Jul 6, 2021
Darksonn
added a commit
that referenced
this pull request
Jul 8, 2021
benesch
added a commit
to benesch/materialize
that referenced
this pull request
Jul 12, 2021
tokio-rs/tokio#3934 changed the semantics of JoinHandle::abort such that you have to await the underlying task to actually deliver the abort. Do so, to fix a stall in `test_tail_shutdown` caused by the connection not actually getting aborted.
aljoscha
pushed a commit
to aljoscha/materialize
that referenced
this pull request
Jul 21, 2021
tokio-rs/tokio#3934 changed the semantics of JoinHandle::abort such that you have to await the underlying task to actually deliver the abort. Do so, to fix a stall in `test_tail_shutdown` caused by the connection not actually getting aborted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3929