Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use qualified syntax when polling in select! #4192

Merged
merged 1 commit into from
Oct 25, 2021
Merged

use qualified syntax when polling in select! #4192

merged 1 commit into from
Oct 25, 2021

Conversation

ibraheemdev
Copy link
Contributor

This improves error messages.

taiki-e
taiki-e approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit e7d3e0c into tokio-rs:master Oct 25, 2021
@taiki-e taiki-e added the M-macros Module: macros in the main Tokio crate label Oct 25, 2021
@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Oct 25, 2021
@Darksonn Darksonn mentioned this pull request Oct 26, 2021
Merged
oliver-giersch pushed a commit to oliver-giersch/tokio that referenced this pull request Oct 28, 2021
@ibraheemdev
macros: use qualified syntax when polling in select! (tokio-rs#4192)
dbb563e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-macros Module: macros in the main Tokio crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibraheemdev @taiki-e @Darksonn