Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow miri to use latest nightly once again #4833

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Noah-Kennedy
Copy link
Contributor

@Noah-Kennedy Noah-Kennedy commented Jul 13, 2022

This reverts #4825, as miri seems to be working again on the latest nightly.

I had originally thought it was this issue with rustup which was to blame, but this seems to be wrong: rust-lang/rustup#3031

This reverts [#4825], which was to address Miri being broken on the latest nightly, possibly due to an issue in rustup.

Rustup issue: rust-lang/rustup#3031

[#4825]: #4825
@Noah-Kennedy Noah-Kennedy marked this pull request as ready for review July 13, 2022 14:06
@Noah-Kennedy Noah-Kennedy enabled auto-merge (squash) July 13, 2022 14:08
@Noah-Kennedy Noah-Kennedy disabled auto-merge July 13, 2022 14:37
@Noah-Kennedy
Copy link
Contributor Author

Hmm, if this is rustup, why would changing the nightly version have fixed the issue in the first place?

@Noah-Kennedy
Copy link
Contributor Author

@jyn514 any idea what else might have changed?

@jyn514
Copy link
Contributor

jyn514 commented Jul 13, 2022

@Noah-Kennedy what was the original issue you were trying to fix by pinning a nightly?

@Noah-Kennedy
Copy link
Contributor Author

@jyn514 we were getting failures in our miri ci job like this: https://github.com/tokio-rs/tokio/runs/7294218581?check_suite_focus=true

@jyn514
Copy link
Contributor

jyn514 commented Jul 13, 2022

Hmm, not sure how that could happen. the "invalid JSON" error is especially strange.

Maybe this is just a miri regression that was fixed in latest nightly?

@Noah-Kennedy
Copy link
Contributor Author

That seems to be the most likely scenario.

@Noah-Kennedy
Copy link
Contributor Author

Updated PR description.

@Darksonn Darksonn added the A-ci Area: The continuous integration setup label Jul 13, 2022
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Noah-Kennedy Noah-Kennedy merged commit 5cf22e4 into master Jul 13, 2022
@Noah-Kennedy Noah-Kennedy deleted the noah/try-unrevert-miri branch July 13, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants