-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow miri to use latest nightly once again #4833
Conversation
This reverts [#4825], which was to address Miri being broken on the latest nightly, possibly due to an issue in rustup. Rustup issue: rust-lang/rustup#3031 [#4825]: #4825
Hmm, if this is rustup, why would changing the nightly version have fixed the issue in the first place? |
@jyn514 any idea what else might have changed? |
@Noah-Kennedy what was the original issue you were trying to fix by pinning a nightly? |
@jyn514 we were getting failures in our miri ci job like this: https://github.com/tokio-rs/tokio/runs/7294218581?check_suite_focus=true |
Hmm, not sure how that could happen. the "invalid JSON" error is especially strange. Maybe this is just a miri regression that was fixed in latest nightly? |
That seems to be the most likely scenario. |
Updated PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts #4825, as miri seems to be working again on the latest nightly.
I had originally thought it was this issue with rustup which was to blame, but this seems to be wrong: rust-lang/rustup#3031