Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to windows-sys #5204

Merged
merged 12 commits into from
Nov 22, 2022
Merged

Port to windows-sys #5204

merged 12 commits into from
Nov 22, 2022

Conversation

kennykerr
Copy link
Contributor

This update ports tokio to the windows-sys crate.

Fixes #5201

@kennykerr kennykerr mentioned this pull request Nov 17, 2022
Closed
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-net Module: tokio/net M-fs Module: tokio/fs M-process Module: tokio/process M-signal Module: tokio/signal labels Nov 17, 2022
@kennykerr
Copy link
Contributor Author

Hmm, I'm starting to see why those placeholder types were present doc generation... Will try to get that fixed up.

@Darksonn
Copy link
Contributor

It seems like I accidentally pressed the button to merge master into your PR.

Darksonn
Darksonn reviewed Nov 20, 2022
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read through the entire PR. I'm happy to accept this PR once docs work and CI passes.

@kennykerr
Copy link
Contributor Author

Thanks, I tested this separately and it now compiles the docs correctly. I also removed the links, and it should now also generate links automatically.

Darksonn
Darksonn reviewed Nov 22, 2022
View reviewed changes
tokio/Cargo.toml Outdated Show resolved Hide resolved
tokio/src/net/windows/named_pipe.rs Outdated Show resolved Hide resolved
Darksonn
Darksonn approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

@Darksonn Darksonn enabled auto-merge (squash) November 22, 2022 16:00
@Darksonn Darksonn merged commit 299bd6a into tokio-rs:master Nov 22, 2022
@messense messense mentioned this pull request Nov 24, 2022
Merged
This was referenced Nov 28, 2022
Closed
Merged
carllerche added a commit that referenced this pull request Dec 5, 2022
@carllerche
chore: prepare Tokio v1.23 release
a59b2f0 
 - net: fix Windows named pipe connect ([#5208])
 - io: support vectored writes for `ChildStdin` ([#5216])
 - io: fix `async fn ready()` false positive for OS-specific events ([#5231])

 ### Changed
 - runtime: `yield_now` defers task until after driver poll ([#5223])
 - runtime: reduce amount of codegen needed per spawned task ([#5213])
 - windows: replace `winapi` dependency with `windows-sys` ([#5204])

 [#5208]: #5208
 [#5216]: #5216
 [#5213]: #5213
 [#5204]: #5204
 [#5223]: #5223
 [#5231]: #5231
@carllerche carllerche mentioned this pull request Dec 5, 2022
Merged
carllerche added a commit that referenced this pull request Dec 5, 2022
@carllerche
chore: prepare Tokio v1.23 release (#5270)
3ce5a26 
### Fixed
 - net: fix Windows named pipe connect ([#5208])
 - io: support vectored writes for `ChildStdin` ([#5216])
 - io: fix `async fn ready()` false positive for OS-specific events ([#5231])

 ### Changed
 - runtime: `yield_now` defers task until after driver poll ([#5223])
 - runtime: reduce amount of codegen needed per spawned task ([#5213])
 - windows: replace `winapi` dependency with `windows-sys` ([#5204])

 [#5208]: #5208
 [#5216]: #5216
 [#5213]: #5213
 [#5204]: #5204
 [#5223]: #5223
 [#5231]: #5231
@uklotzde uklotzde mentioned this pull request Dec 8, 2022
Closed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Dec 23, 2022
Update Rust crate tokio to 1.23.0 (#1687)
2b7040c 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dependencies | minor | `1.22.0` -> `1.23.0` |
| [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dev-dependencies | minor | `1.22.0` -> `1.23.0` |

---

### Release Notes

<details>
<summary>tokio-rs/tokio</summary>

### [`v1.23.0`](https://github.com/tokio-rs/tokio/releases/tag/tokio-1.23.0): Tokio v1.23.0

[Compare Source](tokio-rs/tokio@tokio-1.22.0...tokio-1.23.0)

##### Fixed

-   net: fix Windows named pipe connect ([#&#8203;5208])
-   io: support vectored writes for `ChildStdin` ([#&#8203;5216])
-   io: fix `async fn ready()` false positive for OS-specific events ([#&#8203;5231])

##### Changed

-   runtime: `yield_now` defers task until after driver poll ([#&#8203;5223])
-   runtime: reduce amount of codegen needed per spawned task ([#&#8203;5213])
-   windows: replace `winapi` dependency with `windows-sys` ([#&#8203;5204])

[#&#8203;5208]: tokio-rs/tokio#5208

[#&#8203;5216]: tokio-rs/tokio#5216

[#&#8203;5213]: tokio-rs/tokio#5213

[#&#8203;5204]: tokio-rs/tokio#5204

[#&#8203;5223]: tokio-rs/tokio#5223

[#&#8203;5231]: tokio-rs/tokio#5231

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43MC4wIiwidXBkYXRlZEluVmVyIjoiMzQuNzAuMCJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1687
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@kennykerr kennykerr deleted the port branch November 17, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-fs Module: tokio/fs M-net Module: tokio/net M-process Module: tokio/process M-signal Module: tokio/signal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port to windows-sys
2 participants
@kennykerr @Darksonn