Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: assert compatibility between LengthDelimitedCodec options #6414

Merged
merged 13 commits into from
Mar 23, 2024
Merged

util: assert compatibility between LengthDelimitedCodec options #6414

merged 13 commits into from
Mar 23, 2024

Conversation

maminrayej
Copy link
Member

@maminrayej maminrayej commented Mar 19, 2024 •
edited
Loading

Resolves #5080.

@maminrayej maminrayej added the A-tokio-util Area: The tokio-util crate label Mar 19, 2024
@maminrayej maminrayej marked this pull request as ready for review March 19, 2024 22:43
@Darksonn Darksonn added the M-codec Module: tokio-util/codec label Mar 20, 2024
maminrayej and others added 2 commits March 23, 2024 14:14
@maminrayej @Darksonn
Update tokio-util/src/codec/length_delimited.rs
52ca017 
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
@maminrayej
fix type issue
2fec6fb
@maminrayej maminrayej merged commit 8342e4b into tokio-rs:master Mar 23, 2024
75 checks passed
@Darksonn Darksonn mentioned this pull request May 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-codec Module: tokio-util/codec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LengthDelimitedCodec::length_field_type()/length_field_len() should also update max_frame_length
2 participants
@maminrayej @Darksonn