sync: add #[must_use] to Notified
#6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
requested changes
Sep 5, 2024
xoac
force-pushed
the
chore/add-must_use-for-notfied
branch
from
2fbcc61
to
dc5abb5
Compare
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Oct 23, 2024
Bumps tokio from 1.40.0 to 1.41.0. Release notes Sourced from tokio's releases. Tokio v1.41.0 1.41.0 (Oct 22th, 2024) Added metrics: stabilize global_queue_depth (#6854, #6918) net: add conversions for unix SocketAddr (#6868) sync: add watch::Sender::sender_count (#6836) sync: add mpsc::Receiver::blocking_recv_many (#6867) task: stabilize Id apis (#6793, #6891) Added (unstable) metrics: add H2 Histogram option to improve histogram granularity (#6897) metrics: rename some histogram apis (#6924) runtime: add LocalRuntime (#6808) Changed runtime: box futures larger than 16k on release mode (#6826) sync: add #[must_use] to Notified (#6828) sync: make watch cooperative (#6846) sync: make broadcast::Receiver cooperative (#6870) task: add task size to tracing instrumentation (#6881) wasm: enable cfg_fs for wasi target (#6822) Fixed net: fix regression of abstract socket path in unix socket (#6838) Documented io: recommend OwnedFd with AsyncFd (#6821) io: document cancel safety of AsyncFd methods (#6890) macros: render more comprehensible documentation for join and try_join (#6814, #6841) net: fix swapped examples for TcpSocket::set_nodelay and TcpSocket::nodelay (#6840) sync: document runtime compatibility (#6833) #6793: tokio-rs/tokio#6793 #6808: tokio-rs/tokio#6808 #6810: tokio-rs/tokio#6810 #6814: tokio-rs/tokio#6814 #6821: tokio-rs/tokio#6821 #6822: tokio-rs/tokio#6822 #6826: tokio-rs/tokio#6826 #6828: tokio-rs/tokio#6828 #6833: tokio-rs/tokio#6833 #6836: tokio-rs/tokio#6836 #6838: tokio-rs/tokio#6838 #6840: tokio-rs/tokio#6840 ... (truncated) Commits 01e04da chore: prepare Tokio v1.41.0 (#6917) 92ccade runtime: fix stability feature flags for docs (#6909) fbfeb9a metrics: rename *_poll_count_* to *_poll_time_* (#6924) da745ff metrics: add H2 Histogram option to improve histogram granularity (#6897) ce1c74f metrics: fix deadlock in injection_queue_depth_multi_thread test (#6916) 28c9a14 metrics: rename injection_queue_depth to global_queue_depth (#6918) 32e0b43 ci: freeze FreeBSD and wasm-unknown-unknown on rustc 1.81 (#6911) 1656d8e sync: add mpsc::Receiver::blocking_recv_many (#6867) c9e998e ci: print the correct sort order of the dictionary on failure (#6905) 512e9de rt: add LocalRuntime (#6808) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To prevent situation as in these "bug" report: #6827
Solution
Add #[must_use] to print warning while compiling or checking