Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix typo in build test instructions #7004

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

leopardracer
Copy link
Contributor

This pull request contains changes to improve clarity, correctness and structure.

Description correction:
Corrected "fail" to "fails".

Please review the changes and let me know if any additional changes are needed.

@leopardracer leopardracer changed the title Update README.md fix: typos in documentation files Dec 2, 2024
@@ -6,5 +6,5 @@ To run all of the tests in this directory, run the following commands:
cargo test --features full
cargo test --features rt
```
If one of the tests fail, you can pass `TRYBUILD=overwrite` to the `cargo test`
If one of the tests fails, you can pass `TRYBUILD=overwrite` to the `cargo test`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Actually, I would prefer to change it to plural instead:

Suggested change
If one of the tests fails, you can pass `TRYBUILD=overwrite` to the `cargo test`
If any of the tests fail, you can pass `TRYBUILD=overwrite` to the `cargo test`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected!

@Darksonn Darksonn added the A-readme Area: Documentation that isn't part of any crate such as README.md or CONTRIBUTING.md label Dec 3, 2024
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn changed the title fix: typos in documentation files tests: fix typo in build test instructions Dec 3, 2024
@Darksonn Darksonn enabled auto-merge (squash) December 3, 2024 12:50
@Darksonn Darksonn merged commit af9c683 into tokio-rs:master Dec 3, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-readme Area: Documentation that isn't part of any crate such as README.md or CONTRIBUTING.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants