Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tokio-trace #827

Merged
merged 61 commits into from
Feb 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
c4cf988
Add `tokio-trace-core` crate
hawkw Jan 3, 2019
b60d478
Add `tokio-trace` crate
hawkw Jan 3, 2019
c1212f0
Add licenses
hawkw Jan 3, 2019
754d4b6
Add a README to `tokio-trace`
hawkw Jan 3, 2019
8a10214
Add more examples and usage information to the tokio-trace readme
hawkw Jan 3, 2019
00fa609
Add a README to the `tokio-trace-core` crate
hawkw Jan 3, 2019
36059f6
Add new docs/examples from READMEs to RustDoc
hawkw Jan 3, 2019
bab2f40
Integrate upstream changes
hawkw Jan 3, 2019
cf3ee71
Support setting targets in log-like event macros
hawkw Jan 3, 2019
4720652
Make doctest examples more compile-y
hawkw Jan 3, 2019
5b07f84
Disallow bad stuff in tokio-trace-core
hawkw Jan 3, 2019
f226df0
Add support for no-message `event!` macro invocations
hawkw Jan 4, 2019
234ce89
Fix event macros with more than one field
hawkw Jan 4, 2019
7ea47e3
Add RustDocs and examples to all event macros
hawkw Jan 4, 2019
53d8159
Add real tests for macros
hawkw Jan 4, 2019
9d1f6d8
Handle missing cases for event! macro
hawkw Jan 4, 2019
3db8af9
Stop benchmarks from breaking the build
hawkw Jan 4, 2019
25f7eea
*Actually* fix benchmarks breaking the build
hawkw Jan 4, 2019
603d39f
Clean up weird code in benchmarks
hawkw Jan 4, 2019
1c31da1
A nonexistant subscriber should never be interested
hawkw Jan 4, 2019
13caf1e
Update copyright date in tokio-trace/LICENSE
seanmonstar Jan 4, 2019
39947e9
Document when to use spans versus events
hawkw Jan 4, 2019
3e00d91
Remove vestigial lifetime
hawkw Jan 4, 2019
b7f51fc
Seal the field::Record and field::AsField traits
hawkw Jan 4, 2019
5c3935b
Document why events in log-like macros are dropped
hawkw Jan 4, 2019
a75120e
Use a drop guard in dispatcher::with_default
hawkw Jan 4, 2019
2108be8
Change deny attribute to match tokio-sync
carllerche Jan 14, 2019
4855fb2
Update date in tokio-trace/tokio-trace-core/LICENSE
carllerche Jan 15, 2019
788fb88
Remove weird glob import
hawkw Jan 15, 2019
35aefd0
Rename `field_named` -> `field`
hawkw Jan 15, 2019
6745db6
Rename `remove_interest` -> `clear_interest`
hawkw Jan 15, 2019
851662e
Misc cleanup
hawkw Jan 15, 2019
6072167
Replace `Interest` consts with functions
hawkw Jan 15, 2019
ecd7bb1
Make Field::name infallible
hawkw Jan 15, 2019
7c4fa3e
Move CURRENT_DISPATCH to tokio-trace-core
hawkw Jan 15, 2019
194e404
Assorted minor docs fixes
hawkw Jan 15, 2019
30088ab
Add examples for tokio-trace-core macros
hawkw Jan 15, 2019
5acc8bc
More assorted docs fixes
hawkw Jan 15, 2019
7eeeae6
`Dispatch` no longer implements `Subscriber`
hawkw Jan 15, 2019
9478dbe
Hide more of `-core` from the `tokio-trace` docs
hawkw Jan 15, 2019
39eded2
Remove `CurrentSpanPerThread`
hawkw Jan 15, 2019
1808355
rustfmt
hawkw Jan 15, 2019
3991923
fix em dashes for @davidbarsky
hawkw Jan 15, 2019
cd8e609
Fix typo
hawkw Jan 17, 2019
eb438ef
Span::close should close spans immediately
hawkw Jan 17, 2019
9d018ea
More docs improvement
hawkw Jan 17, 2019
e867ffc
Inline `Interest::is_*`
hawkw Jan 18, 2019
f0170be
Inline the hottest `Span` methods
hawkw Jan 18, 2019
d1195ef
macros: Move test for NEVER interest to callsite
hawkw Jan 18, 2019
096b3a7
All event invocations should skip the never case
hawkw Jan 18, 2019
9dc0129
trace: Improve support for batching field values (#880)
hawkw Feb 6, 2019
fc2fa65
Re-introduce `ValueSet` length limit
hawkw Feb 6, 2019
e56cb74
Add some utility impls for `Record`
hawkw Feb 7, 2019
7f590f5
Fix callsite macro not accepting string field names
hawkw Feb 7, 2019
f2c8354
Add From<Subscriber> impl for Dispatch
hawkw Feb 7, 2019
93e66e6
tokio-trace: Extend macros to allow trailing commas (#891)
kleimkuhler Feb 12, 2019
4b163eb
tokio-trace: Extend `span!` rules (#893)
kleimkuhler Feb 12, 2019
d3e5735
Don't publish `tokio-trace`/`tokio-trace-core` yet
hawkw Feb 19, 2019
37c4dcb
Rename `Enter` to `Inner`
hawkw Feb 19, 2019
f07bcc2
*Actually* rename `Enter` to `Inner`
hawkw Feb 19, 2019
bf798d9
run rustfmt
hawkw Feb 19, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ members = [
"tokio-timer",
"tokio-tcp",
"tokio-tls",
"tokio-trace",
"tokio-trace/tokio-trace-core",
"tokio-udp",
"tokio-uds",
]
Expand Down
30 changes: 30 additions & 0 deletions tokio-trace/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
[package]
name = "tokio-trace"
version = "0.0.1"
authors = ["Eliza Weisman <eliza@buoyant.io>"]
license = "MIT"
repository = "https://github.com/tokio-rs/tokio"
homepage = "https://tokio.rs"
description = """
A scoped, structured logging and diagnostics system.
"""
categories = ["development-tools::debugging", "asynchronous"]
keywords = ["logging", "tracing"]

# Not yet ready for production.
publish = false

[dependencies]
tokio-trace-core = { path = "tokio-trace-core" }

[dev-dependencies]
ansi_term = "0.11"
humantime = "1.1.1"
futures = "0.1"
log = "0.4"

# These are used for the "basic" example from the tokio-trace-prototype repo,
# which is currently not included as it used the `tokio-trace-log` crate, and
# that crate is currently unstable.
# env_logger = "0.5"
# tokio-trace-log = { path = "../tokio-trace-log" }
25 changes: 25 additions & 0 deletions tokio-trace/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
Copyright (c) 2019 Tokio Contributors

Permission is hereby granted, free of charge, to any
person obtaining a copy of this software and associated
documentation files (the "Software"), to deal in the
Software without restriction, including without
limitation the rights to use, copy, modify, merge,
publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software
is furnished to do so, subject to the following
conditions:

The above copyright notice and this permission notice
shall be included in all copies or substantial portions
of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF
ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED
TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A
PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR
IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
168 changes: 168 additions & 0 deletions tokio-trace/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,168 @@
# tokio-trace

A scoped, structured logging and diagnostics system.

## Overview

`tokio-trace` is a framework for instrumenting Rust programs to collect
structured, event-based diagnostic information.

In asynchronous systems like Tokio, interpreting traditional log messages can
often be quite challenging. Since individual tasks are multiplexed on the same
thread, associated events and log lines are intermixed making it difficult to
trace the logic flow. `tokio-trace` expands upon logging-style diagnostics by
allowing libraries and applications to record structured events with additional
information about *temporality* and *causality* — unlike a log message, a span
in `tokio-trace` has a beginning and end time, may be entered and exited by the
flow of execution, and may exist within a nested tree of similar spans. In
addition, `tokio-trace` spans are *structured*, with the ability to record typed
data as well as textual messages.

The `tokio-trace` crate provides the APIs necessary for instrumenting libraries
and applications to emit trace data.

## Usage

First, add this to your `Cargo.toml`:

```toml
[dependencies]
tokio-trace = { git = "https://github.com/tokio-rs/tokio" }
```

Next, add this to your crate:

```rust
#[macro_use]
extern crate tokio_trace;
```

This crate provides macros for creating `Span`s and `Event`s, which represent
davidbarsky marked this conversation as resolved.
Show resolved Hide resolved
periods of time and momentary events within the execution of a program,
respectively.

As a rule of thumb, _spans_ should be used to represent discrete units of work
(e.g., a given request's lifetime in a server) or periods of time spent in a
given context (e.g., time spent interacting with an instance of an external
system, such as a database). In contrast, _events_ should be used to represent
points in time within a span — a request returned with a given status code,
_n_ new items were taken from a queue, and so on.

`Span`s are constructed using the `span!` macro, and then _entered_
to indicate that some code takes place within the context of that `Span`:

```rust
// Construct a new span named "my span".
let mut span = span!("my span");
span.enter(|| {
// Any trace events in this closure or code called by it will occur within
// the span.
});
// Dropping the span will close it, indicating that it has ended.
```

The `Event` type represent an event that occurs instantaneously, and is
essentially a `Span` that cannot be entered. They are created using the `event!`
macro:

```rust
use tokio_trace::Level;
event!(Level::INFO, "something has happened!");
```

Users of the [`log`] crate should note that `tokio-trace` exposes a set of macros for
creating `Event`s (`trace!`, `debug!`, `info!`, `warn!`, and `error!`) which may
be invoked with the same syntax as the similarly-named macros from the `log`
crate. Often, the process of converting a project to use `tokio-trace` can begin
with a simple drop-in replacement.

Let's consider the `log` crate's yak-shaving example:

```rust
#[macro_use]
extern crate tokio_trace;
use tokio_trace::field;

pub fn shave_the_yak(yak: &mut Yak) {
// Create a new span for this invocation of `shave_the_yak`, annotated
// with the yak being shaved as a *field* on the span.
span!("shave_the_yak", yak = field::debug(&yak)).enter(|| {
// Since the span is annotated with the yak, it is part of the context
// for everything happening inside the span. Therefore, we don't need
// to add it to the message for this event, as the `log` crate does.
info!(target: "yak_events", "Commencing yak shaving");

loop {
match find_a_razor() {
Ok(razor) => {
// We can add the razor as a field rather than formatting it
// as part of the message, allowing subscribers to consume it
// in a more structured manner:
info!({ razor = field::display(razor) }, "Razor located");
yak.shave(razor);
break;
}
Err(err) => {
// However, we can also create events with formatted messages,
// just as we would for log records.
warn!("Unable to locate a razor: {}, retrying", err);
}
}
}
})
}
```

You can find examples showing how to use this crate in the examples directory.
davidbarsky marked this conversation as resolved.
Show resolved Hide resolved

### In libraries

Libraries should link only to the `tokio-trace` crate, and use the provided
macros to record whatever information will be useful to downstream consumers.

### In executables

In order to record trace events, executables have to use a `Subscriber`
implementation compatible with `tokio-trace`. A `Subscriber` implements a way of
collecting trace data, such as by logging it to standard output.

Unlike the `log` crate, `tokio-trace` does *not* use a global `Subscriber` which
is initialized once. Instead, it follows the `tokio` pattern of executing code
in a context. For example:

```rust
#[macro_use]
extern crate tokio_trace;

let my_subscriber = FooSubscriber::new();

tokio_trace::subscriber::with_default(subscriber, || {
// Any trace events generated in this closure or by functions it calls
// will be collected by `my_subscriber`.
})
```

This approach allows trace data to be collected by multiple subscribers within
different contexts in the program. Alternatively, a single subscriber may be
constructed by the `main` function and all subsequent code executed with that
subscriber as the default. Any trace events generated outside the context of a
subscriber will not be collected.

The executable itself may use the `tokio-trace` crate to instrument itself as
well.

The [`tokio-trace-nursery`] repository contains less stable crates designed to
be used with the `tokio-trace` ecosystem. It includes a collection of
`Subscriber` implementations, as well as utility and adapter crates.

[`log`]: https://docs.rs/log/0.4.6/log/

## License

This project is licensed under the [MIT license](LICENSE).

### Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in Tokio by you, shall be licensed as MIT, without any additional
terms or conditions.
44 changes: 44 additions & 0 deletions tokio-trace/benches/no_subscriber.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
#![feature(test)]
#[macro_use]
extern crate tokio_trace;
#[macro_use]
extern crate log;
extern crate test;
use test::Bencher;

#[bench]
fn bench_span_no_subscriber(b: &mut Bencher) {
b.iter(|| {
span!("span");
});
}

#[bench]
fn bench_log_no_logger(b: &mut Bencher) {
b.iter(|| {
log!(log::Level::Info, "log");
});
}

#[bench]
fn bench_costly_field_no_subscriber(b: &mut Bencher) {
b.iter(|| {
span!(
"span",
foo = tokio_trace::field::display(format!("bar {:?}", 2))
);
});
}

#[bench]
fn bench_no_span_no_subscriber(b: &mut Bencher) {
b.iter(|| {});
}

#[bench]
fn bench_1_atomic_load(b: &mut Bencher) {
// This is just included as a baseline.
use std::sync::atomic::{AtomicUsize, Ordering};
let foo = AtomicUsize::new(1);
b.iter(|| foo.load(Ordering::Relaxed));
}
Loading