Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio-trace: Extend span! rules #893

Merged

Conversation

kleimkuhler
Copy link
Contributor

Add the ability to define a target and log level for
individual spans.

level: ... must be included since both $lvl and $name are expr.

The macro tests and documentation tests have been extended.

Signed-off-by: Kevin Leimkuhler kevinl@buoyant.io

Add the ability to define a target and log level for
individual spans.

`level: ...` must be included since both `$lvl` and `$name` are `expr`.

The macro tests and documentation tests have been extended.

Signed-off-by: Kevin Leimkuhler <kevinl@buoyant.io>
@hawkw hawkw self-requested a review February 12, 2019 18:41
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

I commented on a few minor things, but I'm happy to merge this branch now in its current state. Let me know if you want to address anything I mentioned, and I can wait to merge.

tokio-trace/tests/macros.rs Show resolved Hide resolved
tokio-trace/src/lib.rs Show resolved Hide resolved
tokio-trace/src/lib.rs Outdated Show resolved Hide resolved
Change default log level of `span!` to `TRACE` to reflect the default
level used in `callsite!`.

Signed-off-by: Kevin Leimkuhler <kevinl@buoyant.io>
@kleimkuhler
Copy link
Contributor Author

@hawkw A mock subscriber test has been added that tests for a certain target and lvl. I also changed the default log level from DEBUG to TRACE to reflect the default log level that is currently used by callsite!.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! :D

tokio-trace/tests/span.rs Show resolved Hide resolved
@hawkw hawkw merged commit 4b163eb into tokio-rs:eliza/tokio-trace Feb 12, 2019
@kleimkuhler kleimkuhler deleted the kleimkuhler/extend-span-rules branch February 12, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants