Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing-journald pulling in default features of dependencies #1465

Closed
themaxdavitt opened this issue Jul 12, 2021 · 4 comments · Fixed by #1476
Closed

tracing-journald pulling in default features of dependencies #1465

themaxdavitt opened this issue Jul 12, 2021 · 4 comments · Fixed by #1476
Labels
kind/bug Something isn't working

Comments

@themaxdavitt
Copy link
Contributor

Bug Report

Version

├── tracing v0.1.26
│   ├── tracing-attributes v0.1.15 (proc-macro)
│   └── tracing-core v0.1.18
├── tracing-journald v0.1.0
│   ├── tracing-core v0.1.18 (*)
│   └── tracing-subscriber v0.2.19
│       ├── tracing v0.1.26 (*)
│       ├── tracing-core v0.1.18 (*)
│       ├── tracing-log v0.1.2
│       │   └── tracing-core v0.1.18 (*)
│       └── tracing-serde v0.1.2
│           └── tracing-core v0.1.18 (*)
└── tracing-subscriber v0.2.19 (*)

Platform

Not relevant.

Description

I was looking to reduce the size of my dependency tree and noticed that tracing-journald is pulling in the default features of tracing-core and tracing-subscriber, which adds many unneeded dependencies (this can be partially seen in the version section, e.g. I don't need tracing-serde). I'm not the most familiar with the tracing ecosystem but I believe this is unnecessary.
@hawkw
Copy link
Member

hawkw commented Jul 12, 2021

Yup, we should fix that --- good catch, thanks for reporting!

@hawkw hawkw added the kind/bug Something isn't working label Jul 12, 2021
@themaxdavitt themaxdavitt mentioned this issue Jul 19, 2021
Merged
hawkw pushed a commit that referenced this issue May 9, 2022
@themaxdavitt
journald: disable default features of tracing-subscriber (#1476)
6bae73b 
## Motivation

Closes #1465.

## Solution

I'm just disabling the default features of `tracing-journald`'s
dependency on `tracing-subscriber`. The original issue talked about the
crate's dependencies more broadly but considering that the standard
library is already depended upon I didn't think it made sense to change
the `tracing-core` dependency's features (which are just `no_std`
support).
hawkw pushed a commit that referenced this issue Jun 6, 2022
@themaxdavitt @hawkw
journald: disable default features of tracing-subscriber (#1476)
6878d8d 
## Motivation

Closes #1465.

## Solution

I'm just disabling the default features of `tracing-journald`'s
dependency on `tracing-subscriber`. The original issue talked about the
crate's dependencies more broadly but considering that the standard
library is already depended upon I didn't think it made sense to change
the `tracing-core` dependency's features (which are just `no_std`
support).
hawkw pushed a commit that referenced this issue Jun 7, 2022
@themaxdavitt @hawkw
journald: disable default features of tracing-subscriber (#1476)
e8f7754 
## Motivation

Closes #1465.

## Solution

I'm just disabling the default features of `tracing-journald`'s
dependency on `tracing-subscriber`. The original issue talked about the
crate's dependencies more broadly but considering that the standard
library is already depended upon I didn't think it made sense to change
the `tracing-core` dependency's features (which are just `no_std`
support).
@swsnr
Copy link
Contributor

swsnr commented Oct 27, 2022

@hawkw Could you make a release of tracing-journald with this change included?

@swsnr
Copy link
Contributor

swsnr commented Nov 24, 2022

@hawkw Ping 😊

@swsnr
Copy link
Contributor

swsnr commented Sep 28, 2023

@hawkw Another friendly ping 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

journald: disable default features of tracing-subscriber
3 participants
@swsnr @hawkw @themaxdavitt