Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-core referring to documentation for an old version #2383

Closed
LukeMathWalker opened this issue Nov 15, 2022 · 2 comments · Fixed by #2384
Closed

tracing-core referring to documentation for an old version #2383

LukeMathWalker opened this issue Nov 15, 2022 · 2 comments · Fixed by #2384

Comments

@LukeMathWalker
Copy link
Contributor

While working on some cursed projects, this line in tracing-core came to my attention.

Is there a reason why we pin the HTML root for the docs to the documentation generated for 0.1.17, while the current latest is 0.1.30?

@hawkw
Copy link
Member

hawkw commented Nov 15, 2022

No reason, I think I just forgot to update that. In fact, I believe that attribute is no longer necessary and can be removed entirely.

@LukeMathWalker
Copy link
Contributor Author

Awesome - I have opened two PRs to rip them out then 🙇🏻

hawkw pushed a commit that referenced this issue Apr 21, 2023
Fixes #2383.
; Conflicts:
;	tracing-appender/src/lib.rs
;	tracing-attributes/src/lib.rs
;	tracing-core/src/lib.rs
;	tracing-error/src/lib.rs
;	tracing-futures/src/lib.rs
;	tracing-log/src/lib.rs
;	tracing-opentelemetry/src/lib.rs
;	tracing-serde/src/lib.rs
;	tracing-subscriber/src/lib.rs
;	tracing/src/lib.rs
hawkw pushed a commit that referenced this issue Apr 21, 2023
Fixes #2383.
; Conflicts:
;	tracing-appender/src/lib.rs
;	tracing-attributes/src/lib.rs
;	tracing-core/src/lib.rs
;	tracing-error/src/lib.rs
;	tracing-futures/src/lib.rs
;	tracing-log/src/lib.rs
;	tracing-opentelemetry/src/lib.rs
;	tracing-serde/src/lib.rs
;	tracing-subscriber/src/lib.rs
;	tracing/src/lib.rs
kaffarell pushed a commit to kaffarell/tracing that referenced this issue May 22, 2024
…rs#2384)

Fixes tokio-rs#2383.
; Conflicts:
;	tracing-appender/src/lib.rs
;	tracing-attributes/src/lib.rs
;	tracing-core/src/lib.rs
;	tracing-error/src/lib.rs
;	tracing-futures/src/lib.rs
;	tracing-log/src/lib.rs
;	tracing-opentelemetry/src/lib.rs
;	tracing-serde/src/lib.rs
;	tracing-subscriber/src/lib.rs
;	tracing/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants