Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1012 #1014

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Oct 4, 2020

Backports: #1012

@hawkw should I directly bump the crate version?

This adds support for having dashes in log target names, like:
`target-name=info`
@bkchr bkchr requested review from hawkw and a team as code owners October 4, 2020 07:28
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@hawkw hawkw merged commit be2f80a into tokio-rs:v0.1.x Oct 5, 2020
@bkchr bkchr deleted the bkchr-dash-target-name-backport branch October 5, 2020 18:17
@hawkw
Copy link
Member

hawkw commented Oct 5, 2020

@hawkw should I directly bump the crate version?

I'll update the crate version & changelog when I do the release (momentarily). Thanks for asking, though!

hawkw added a commit that referenced this pull request Oct 7, 2020
Changed

- Updated `tracing-core` to 0.1.17 ([#992])

Added

- **env-filter**: Added support for filtering on targets which contain
  dashes ([#1014])
- **env-filter**: Added a warning when creating an `EnvFilter` that
  contains directives that would enable a level disabled by the
  `tracing` crate's `static_max_level` features ([#1021])

Thanks to @jyn514 and @bkchr for contributing to this release!

[#992]: #992
[#1014]: #1014
[#1021]: #1021
hawkw added a commit that referenced this pull request Oct 7, 2020
Changed

- Updated `tracing-core` to 0.1.17 ([#992])

Added

- **env-filter**: Added support for filtering on targets which contain
  dashes ([#1014])
- **env-filter**: Added a warning when creating an `EnvFilter` that
  contains directives that would enable a level disabled by the
  `tracing` crate's `static_max_level` features ([#1021])

Thanks to @jyn514 and @bkchr for contributing to this release!

[#992]: #992
[#1014]: #1014
[#1021]: #1021
hawkw added a commit that referenced this pull request Oct 7, 2020
### Changed

- Updated `tracing-core` to 0.1.17 ([#992])

### Added

- **env-filter**: Added support for filtering on targets which contain
  dashes ([#1014])
- **env-filter**: Added a warning when creating an `EnvFilter` that
  contains directives that would enable a level disabled by the
  `tracing` crate's `static_max_level` features ([#1021])

Thanks to @jyn514 and @bkchr for contributing to this release!

[#992]: #992
[#1014]: #1014
[#1021]: #1021
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
### Changed

- Updated `tracing-core` to 0.1.17 ([tokio-rs#992])

### Added

- **env-filter**: Added support for filtering on targets which contain
  dashes ([tokio-rs#1014])
- **env-filter**: Added a warning when creating an `EnvFilter` that
  contains directives that would enable a level disabled by the
  `tracing` crate's `static_max_level` features ([tokio-rs#1021])

Thanks to @jyn514 and @bkchr for contributing to this release!

[tokio-rs#992]: tokio-rs#992
[tokio-rs#1014]: tokio-rs#1014
[tokio-rs#1021]: tokio-rs#1021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants