Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry: Backport Assign default ids if missing #1029

Merged
merged 1 commit into from
Oct 10, 2020
Merged

opentelemetry: Backport Assign default ids if missing #1029

merged 1 commit into from
Oct 10, 2020

Commits on Oct 10, 2020

  1. opentelemetry: Assign default ids if missing 

    ## Motivation

It is currently possible to create a span graph which includes a span
that has both an invalid parent otel context _and_ a missing trace id by
assigning an invalid extracted parent context to a non-root span.
Constructing this particular graph will currently cause a panic.

## Solution

Explicitly assign invalid trace / span ids when sampling using the otel
SDK if the span builder does not contain these values.
    @jtescher
    jtescher committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    71628d6 View commit details
    Browse the repository at this point in the history