attributes: add #[instrument(parent = ...)] for specifying parent span. #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation Resolves part of tokio-rs#879.
|
This is looking so cool! What's the state of this PR? |
|
I'm not working on this PR. If you like it, you can create your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves part of #879.
Solution
This change adds
parentparameter that takes an arbitrary expression to the#[instrument]attribute.If specified, it overrides the parent span of the span made by
#[instrument]Questions
I'm creating this as a draft PR because there are some unclear things. Any ideas and suggestions are welcome.
parentfield blank when unspecified might be better.