backport some stuff #1551
Merged
backport some stuff #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a little bit nicer IMO. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Previously, the Netlify configuration copied the docs into a `_netlify_out` dir as a workaround for netlify/build-image#505. This upstream issue was fixed back in January, so this workaround hasn't been necessary for a while. Therefore, we can remove this extra complexity from our configuration. I also changed the build script to a multi-line string which I think is a bit nicer.
…1544) ## Motivation Currently, some types in the `filter` module that require the "env-filter" feature flag don't properly show in the docs that they require this feature. This is because the `doc(cfg(feature = "env-filter"))` attribute is only placed on the _re-export_ from the `env` module (and on the `EnvFilter` type), not on the individual types that are re-exported. However, placing a `doc(cfg(...))` attribute on a re-export doesn't actually do anything. ## Solution This commit fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogTracernot honoring max level filters (fix: log level filter with trace #1543)doc(cfg(...))attributes forEnvFilter(subscriber: fix missingdoc(cfg(...))attributes forEnvFilter#1544)working-directoryinstead of cd (chore(ci): useworking-directoryinstead of cd #1540)