-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static level tests for spans and instrumented fns #1872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. i had some non-blocking style suggestions --- personally, i would prefer to have separate test cases for events, spans, and #[instrument]
. but, it's not particularly important to me, and i'd happily merge this as-is.
07f5c10
to
4ad6856
Compare
Rebased and split into three tests for events/spans/instrumented fns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks!
The current tests for the compile-time maximum level were not being run in `--release` mode, and did not previously assert anything about `Span`s. This also adds some test cases for various `#[instrument]`-ed functions.
The current tests for the compile-time maximum level were not being run in `--release` mode, and did not previously assert anything about `Span`s. This also adds some test cases for various `#[instrument]`-ed functions.
The current tests for the compile-time maximum level were not being run in `--release` mode, and did not previously assert anything about `Span`s. This also adds some test cases for various `#[instrument]`-ed functions.
The current tests for the compile-time maximum level were not being run in `--release` mode, and did not previously assert anything about `Span`s. This also adds some test cases for various `#[instrument]`-ed functions.
The current tests for the compile-time maximum level were not being run in `--release` mode, and did not previously assert anything about `Span`s. This also adds some test cases for various `#[instrument]`-ed functions.
The current tests for the compile-time maximum level were not being run in `--release` mode, and did not previously assert anything about `Span`s. This also adds some test cases for various `#[instrument]`-ed functions.
…-rs#1872) The current tests for the compile-time maximum level were not being run in `--release` mode, and did not previously assert anything about `Span`s. This also adds some test cases for various `#[instrument]`-ed functions.
The current tests for the compile-time maximum level were not being run in
--release
mode, and did not previously assert anything aboutSpan
s.This also adds some test cases for various
#[instrument]
-ed functions.