Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static level tests for spans and instrumented fns #1872

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

Swatinem
Copy link
Contributor

The current tests for the compile-time maximum level were not being run in --release mode, and did not previously assert anything about Spans.

This also adds some test cases for various #[instrument]-ed functions.

@Swatinem Swatinem requested review from davidbarsky, hawkw and a team as code owners January 28, 2022 14:33
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. i had some non-blocking style suggestions --- personally, i would prefer to have separate test cases for events, spans, and #[instrument]. but, it's not particularly important to me, and i'd happily merge this as-is.

tracing/test_static_max_level_features/tests/test.rs Outdated Show resolved Hide resolved
tracing/test_static_max_level_features/tests/test.rs Outdated Show resolved Hide resolved
tracing/test_static_max_level_features/tests/test.rs Outdated Show resolved Hide resolved
@Swatinem
Copy link
Contributor Author

Rebased and split into three tests for events/spans/instrumented fns.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@hawkw hawkw merged commit dacf855 into tokio-rs:master Jan 29, 2022
hawkw pushed a commit that referenced this pull request Feb 3, 2022
The current tests for the compile-time maximum level were not being run
in `--release` mode, and did not previously assert anything about
`Span`s.

This also adds some test cases for various `#[instrument]`-ed functions.
hawkw pushed a commit that referenced this pull request Feb 3, 2022
The current tests for the compile-time maximum level were not being run
in `--release` mode, and did not previously assert anything about
`Span`s.

This also adds some test cases for various `#[instrument]`-ed functions.
hawkw pushed a commit that referenced this pull request Feb 3, 2022
The current tests for the compile-time maximum level were not being run
in `--release` mode, and did not previously assert anything about
`Span`s.

This also adds some test cases for various `#[instrument]`-ed functions.
hawkw pushed a commit that referenced this pull request Feb 3, 2022
The current tests for the compile-time maximum level were not being run
in `--release` mode, and did not previously assert anything about
`Span`s.

This also adds some test cases for various `#[instrument]`-ed functions.
hawkw pushed a commit that referenced this pull request Feb 3, 2022
The current tests for the compile-time maximum level were not being run
in `--release` mode, and did not previously assert anything about
`Span`s.

This also adds some test cases for various `#[instrument]`-ed functions.
hawkw pushed a commit that referenced this pull request Feb 4, 2022
The current tests for the compile-time maximum level were not being run
in `--release` mode, and did not previously assert anything about
`Span`s.

This also adds some test cases for various `#[instrument]`-ed functions.
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
…-rs#1872)

The current tests for the compile-time maximum level were not being run
in `--release` mode, and did not previously assert anything about
`Span`s.

This also adds some test cases for various `#[instrument]`-ed functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants