Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry: add semconv exception fields #2310

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

jtescher
Copy link
Collaborator

Port #2135 to master branch

When an error value is recorded, it should add the `exception.message`
and `exception.stacktrace` fields from the opentelemetry semantic
conventions to the span/event. Ideally the `exception.type` field would
be provided also, but there is currently not a mechanism to determine
the type name of a trait object.

Co-authored-by: Lily Mara <54288692+lilymara-onesignal@users.noreply.github.com>
@jtescher jtescher added the crate/opentelemetry Related to the `tracing-opentelemetry` crate. label Sep 16, 2022
@jtescher jtescher requested a review from a team as a code owner September 16, 2022 19:10
@hawkw hawkw enabled auto-merge (squash) September 16, 2022 20:09
@hawkw hawkw merged commit 5c35eb0 into master Sep 16, 2022
@hawkw hawkw deleted the jtescher/port-2135 branch September 16, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate/opentelemetry Related to the `tracing-opentelemetry` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants