fix Layered's max_level_hint impl #2317
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes: #2265
Solution
When there are no per-layer filters, the
Layered
pick_level_hint
function is wrong. It prioritizesSome(_)
overNone
, even thoughNone
is basicallySome(TRACE)
. This was not notices because most people are doing one of:None
)In this branch we also have to fix the fmt
Collector
, which implementsCollect
and erroneously passes through to a layer that unconditionally returnsNone
. This is the correct option for the layer itself, but overrides the behavior we want for the subscriber, which is to follow theF
field directly. We setinner_is_registry
directly to combat this problem