Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare a bunch of releases #2749

Closed
wants to merge 9 commits into from

Conversation

davidbarsky
Copy link
Member

Preparing a big release of stuff included (and not included...) in #2728. I'd like to tighten up some of the phrasing in the changelog before we land this, though.

@davidbarsky davidbarsky requested review from a team and hawkw as code owners October 12, 2023 17:46
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changelog nits. Also, I usually try to make the PR numbers in the changelog Markdown links to that PR, can we do that here?

Thanks for working on this!

tracing-appender/CHANGELOG.md Outdated Show resolved Hide resolved
tracing-core/CHANGELOG.md Outdated Show resolved Hide resolved
tracing-core/CHANGELOG.md Outdated Show resolved Hide resolved
tracing-core/CHANGELOG.md Outdated Show resolved Hide resolved
tracing-core/CHANGELOG.md Outdated Show resolved Hide resolved
tracing-journald/CHANGELOG.md Outdated Show resolved Hide resolved
tracing/CHANGELOG.md Outdated Show resolved Hide resolved
tracing/CHANGELOG.md Outdated Show resolved Hide resolved
tracing/CHANGELOG.md Outdated Show resolved Hide resolved
tracing/CHANGELOG.md Outdated Show resolved Hide resolved
@davidbarsky davidbarsky changed the title Davidbarsky/prepare release oct 12 2023 chore: prepare a bunch of releases Oct 12, 2023
@davidbarsky davidbarsky force-pushed the davidbarsky/prepare-release-oct-12-2023 branch 2 times, most recently from 649b6ce to 1210f5c Compare October 12, 2023 22:16
davidbarsky and others added 8 commits October 12, 2023 18:26
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
@davidbarsky davidbarsky force-pushed the davidbarsky/prepare-release-oct-12-2023 branch from 1210f5c to 734b7de Compare October 12, 2023 22:54
@@ -1,6 +1,6 @@
[package]
name = "tracing-log"
version = "0.1.3"
version = "0.1.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This release has a large number of changes to `tracing-appender`:

### Added
- **non_blocking**: -Name spawned worker thread [#2219]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **non_blocking**: -Name spawned worker thread [#2219]
- **non_blocking**: Name spawned worker thread [#2219]

Comment on lines +6 to +15
- **non_blocking**: -Name spawned worker thread [#2219]
- **non_blocking**: Allow worker thread name to be configured [#2365]
- **rolling**: `RollingFileAppender::builder` for configuring `RollingFileAppender`s [#2227]
- **rolling**: `Builder::filename_suffix` method to configure the suffix for log files [#2225]
- **rolling**: `Builder::max_log_files` method to enable automatically deleting old log files [#2323]

### Documented

- **rolling**: Clarify file appender docs [#2689]
- **rolling**: Fix typo in RollingFileAppender docs [#2375]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we put parens around the issue links as well, the way we do in the other changelog entries? sorry.

Suggested change
- **non_blocking**: -Name spawned worker thread [#2219]
- **non_blocking**: Allow worker thread name to be configured [#2365]
- **rolling**: `RollingFileAppender::builder` for configuring `RollingFileAppender`s [#2227]
- **rolling**: `Builder::filename_suffix` method to configure the suffix for log files [#2225]
- **rolling**: `Builder::max_log_files` method to enable automatically deleting old log files [#2323]
### Documented
- **rolling**: Clarify file appender docs [#2689]
- **rolling**: Fix typo in RollingFileAppender docs [#2375]
- **non_blocking**: -Name spawned worker thread ([#2219])
- **non_blocking**: Allow worker thread name to be configured ([#2365])
- **rolling**: `RollingFileAppender::builder` for configuring `RollingFileAppender`s ([#2227])
- **rolling**: `Builder::filename_suffix` method to configure the suffix for log files ([#2225])
- **rolling**: `Builder::max_log_files` method to enable automatically deleting old log files ([#2323])
### Documented
- **rolling**: Clarify file appender docs ([#2689])
- **rolling**: Fix typo in RollingFileAppender docs ([#2375])

Comment on lines +5 to +10
- bump minimum version of proc-macro2 to 1.0.60 [#2732]
- generate less dead code for async block return type hint [#2709]

### Fixed

- fix instrument with "log" feature [#2599]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- bump minimum version of proc-macro2 to 1.0.60 [#2732]
- generate less dead code for async block return type hint [#2709]
### Fixed
- fix instrument with "log" feature [#2599]
- Bump minimum version of proc-macro2 to 1.0.60 ([#2732])
- Generate less dead code for async block return type hint ([#2709])
### Fixed
- Compilation error instrument with "log" feature ([#2599])

Comment on lines +5 to +10
- Fix typo in `field` docs [#2611]
- Remove duplicate wording [#2674]

### Changed

- Allow `ValueSet`s of any length [#2508]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix typo in `field` docs [#2611]
- Remove duplicate wording [#2674]
### Changed
- Allow `ValueSet`s of any length [#2508]
- Fix typo in `field` docs ([#2611])
- Remove duplicate wording ([#2674])
### Changed
- Allow `ValueSet`s of any length ([#2508])

tracing-journald/CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines +5 to +9
- Update env_logger to 0.10 from 0.7 to fix GHSA-g98v-hv3f-hcfr [#2740]

### Fixed

- Fix minimal-versions correctness [#2246]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Update env_logger to 0.10 from 0.7 to fix GHSA-g98v-hv3f-hcfr [#2740]
### Fixed
- Fix minimal-versions correctness [#2246]
- Update env_logger to 0.10 from 0.7 to fix GHSA-g98v-hv3f-hcfr ([#2740])
### Fixed
- Fix minimal-versions correctness ([#2246])

Comment on lines +5 to +12
- **filter**: Implement `layer::Filter` for `Option<Filter>` [#2407]
- **fmt**: Add Chrono implementations for `FormatTime` [#2690]
- **fmt**: Support the `NO_COLOR` environment variable for determining whether `fmt::Layer` should emit ANSI color escape codes [#2647]
- **fmt**: make `format::Writer::new()` public [#2680]

### Documented

- Document `registry` feature requirement for `fmt` feature [#2590]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **filter**: Implement `layer::Filter` for `Option<Filter>` [#2407]
- **fmt**: Add Chrono implementations for `FormatTime` [#2690]
- **fmt**: Support the `NO_COLOR` environment variable for determining whether `fmt::Layer` should emit ANSI color escape codes [#2647]
- **fmt**: make `format::Writer::new()` public [#2680]
### Documented
- Document `registry` feature requirement for `fmt` feature [#2590]
- **filter**: Implement `layer::Filter` for `Option<Filter>` ([#2407])
- **fmt**: Add Chrono implementations for `FormatTime` ([#2690])
- **fmt**: Support the `NO_COLOR` environment variable for determining whether `fmt::Layer` should emit ANSI color escape codes ([#2647])
- **fmt**: make `format::Writer::new()` public ([#2680])
### Documented
- Document `registry` feature requirement for `fmt` feature ([#2590])

Comment on lines +5 to +21
- Allow constant field names in macros [#2617]
- Allow setting event names in macros [#2699]
- Allow `ValueSet`s of any length [#2508]

### Fixed

- Use fully qualified names in macros for items exported from std prelude [#2621]

### Documented

- Add `axum-insights` to relevant crates. [#2713]
- Fix link to RAI pattern crate documentation [#2612]
- Fix docs typos and warnings [#2581]
- Add `clippy-tracing` to related crates [#2628]
- Add `tracing-cloudwatch` to related crates [#2667]
- Fix deadlink to `tracing-etw` repo [#2602]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Allow constant field names in macros [#2617]
- Allow setting event names in macros [#2699]
- Allow `ValueSet`s of any length [#2508]
### Fixed
- Use fully qualified names in macros for items exported from std prelude [#2621]
### Documented
- Add `axum-insights` to relevant crates. [#2713]
- Fix link to RAI pattern crate documentation [#2612]
- Fix docs typos and warnings [#2581]
- Add `clippy-tracing` to related crates [#2628]
- Add `tracing-cloudwatch` to related crates [#2667]
- Fix deadlink to `tracing-etw` repo [#2602]
- Allow constant field names in macros [#2617]
- Allow setting event names in macros [#2699]
- Allow `ValueSet`s of any length [#2508]
### Fixed
- Use fully qualified names in macros for items exported from std prelude [#2621]
### Documented
- Add `axum-insights` to relevant crates. ([#2713])
- Fix link to RAI pattern crate documentation ([#2612])
- Fix docs typos and warnings ([#2581])
- Add `clippy-tracing` to related crates ([#2628])
- Add `tracing-cloudwatch` to related crates ([#2667])
- Fix deadlink to `tracing-etw` repo ([#2602])

@yufan022
Copy link

yufan022 commented Nov 1, 2023

Thanks for your great work! Just want to ask if the process seems to be blocked.
May I ask when the new version is expected to be released? I am looking forward to the RollingFileAppender feature :)

@davidbarsky
Copy link
Member Author

Thanks for your great work! Just want to ask if the process seems to be blocked.

May I ask when the new version is expected to be released? I am looking forward to the RollingFileAppender feature :)

I'll get the remainder (tracing-subscriber, tracing-appender, etc.) out this week. I've been cherry-picking release PRs from this branch.

@hawkw
Copy link
Member

hawkw commented Nov 1, 2023

i haven't been able to work on this too much as i've had COVID, unfortunately.

@davidbarsky i think we'll need to update tracing-subscriber to depend on tracing-log v0.2, and then that should unblock the remaining releases?

@davidbarsky
Copy link
Member Author

davidbarsky commented Nov 1, 2023

i haven't been able to work on this too much as i've had COVID, unfortunately.

@davidbarsky i think we'll need to update tracing-subscriber to depend on tracing-log v0.2, and then that should unblock the remaining releases?

@hawkw yup! i was planning on bumping tracing-subscriber's tracing-log dependency as part of the release prep.

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
@Finomnis
Copy link
Contributor

Looking forward to the tracing-journald 0.4.0 release :)
Any rough idea about a potential release timeline?

@Finomnis
Copy link
Contributor

Any news? I'd be willing to help if it speeds up the process.

@davidbarsky
Copy link
Member Author

Any news? I'd be willing to help if it speeds up the process.

Sorry, let me get #2791 updated. I'll close this PR in the meantime.

@davidbarsky davidbarsky deleted the davidbarsky/prepare-release-oct-12-2023 branch November 21, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants