Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-subscriber: bump tracing-core to 0.1.33 #3176

Open
wants to merge 1 commit into
base: v0.1.x
Choose a base branch
from

Conversation

nkconnor
Copy link

@nkconnor nkconnor commented Dec 18, 2024

#2954 was released in 0.3.19 #3162

Notably, it relied on features from tracing-core 0.1.33, however, the version was never bumped. Users of the tracing feature of tracing-subscriber would have no issue since it pulls in the higher version transitively.

The specific feature used was implementing trait method record_bytes from the field::Visit trait on JsonVisitor from the tracing-subscriber json format module. (see linked #2945, or impl field::Visit for JsonVisitor<'_>)

I believe this dependency mismatch requires users to manually select the higher tracing-core version or suffer compilation failure.

This probably reflects some failure in how the tests utilize features and intra-workspace dependencies, but, a resolution for that is beyond my current comprehension of the project.

@nkconnor nkconnor requested review from hawkw and a team as code owners December 18, 2024 19:23
@nkconnor nkconnor changed the title bump tracing-core to 0.1.33 tracing-subscriber: bump tracing-core to 0.1.33 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant