tracing-subscriber: bump tracing-core to 0.1.33 #3176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2954 was released in 0.3.19 #3162
Notably, it relied on features from tracing-core 0.1.33, however, the version was never bumped. Users of the
tracing
feature oftracing-subscriber
would have no issue since it pulls in the higher version transitively.The specific feature used was implementing trait method
record_bytes
from thefield::Visit
trait onJsonVisitor
from the tracing-subscriber json format module. (see linked #2945, orimpl field::Visit for JsonVisitor<'_>
)I believe this dependency mismatch requires users to manually select the higher tracing-core version or suffer compilation failure.
This probably reflects some failure in how the tests utilize features and intra-workspace dependencies, but, a resolution for that is beyond my current comprehension of the project.